pkg/tfvars: Drop unused libvirt.DefaultIfName and similar #759
Conversation
openshift-ci-robot
added
size/XS
wking
force-pushed
the
drop-unused-libvirt-bridge-name
branch
from
40601ea to
30b12bb
Compare
wking
changed the title
|
/lgtm |
DefaultIfName was added in f245ca6 (installer: validate libvirt, 2018-06-06, coreos/tectonic-installer#3265), but the last consumer was removed by 619db92 (pkg/types/config: Break into pkg/validate and pkg/tfvars, 2018-10-03, openshift#412). We currently feed the default bridge name in via pkg/asset/installconfig/libvirt's defaultNetworkIfName. The AWS and OpenStack default variables I'm also removing here have a similar history and current default location.
wking
force-pushed
the
drop-unused-libvirt-bridge-name
branch
from
30b12bb to
47cd206
Compare
openshift-ci-robot
added
size/S
wking
changed the title
|
I've pushed 30b12bb -> 47cd206 removing similar unused defaults from the AWS and OpenStack subpackages. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
This was added in f245ca6 (coreos/tectonic-installer#3265), but the last consumer was removed by 619db92 (#412). We currently feed the default bridge name in via
pkg/asset/installconfig/libvirt'sdefaultNetworkIfName.